Skip to content

[pull] main from expo:main - #1154

Merged
pull[bot] merged 1 commit into
code:mainfrom
expo:main
Aug 16, 2026
Merged

[pull] main from expo:main#1154
pull[bot] merged 1 commit into
code:mainfrom
expo:main

Conversation

@pull

@pull pull Bot commented Aug 16, 2026

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

# Why

`Asset.getUri()` returns a different rendition per media type on iOS.
Images come back as they
currently look in Photos, videos as originally captured. So a video
edited in Photos resolves
without its edits, and so does `AssetInfo.uri`. The legacy API returns
the current version for
video, so migrating to the current API silently changes what you read.

Found while reviewing #48248, which fixes the same bug in legacy
`expo-file-system`.

# How

- Added a `version` option to `getUri()`, defaulting to the current
rendition for all media types.
- For video, this sets `PHVideoRequestOptions.version`.
- For an original image, we claim the adjustment data so Photos returns
the pre-edit image.
- Android has no such renditions, so it accepts the option and ignores
it.

# Test Plan

- iOS NCL (updated screen)
- iOS test-suite (new tests)

# Checklist

- [x] I added a `changelog.md` entry and rebuilt the package sources
according to [this short
guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).
- [x] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
@pull pull Bot locked and limited conversation to collaborators Aug 16, 2026
@pull pull Bot added the ⤵️ pull label Aug 16, 2026
@pull
pull Bot merged commit 1c44063 into code:main Aug 16, 2026
11 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant